Closed
Conversation
Matthew-Whitlock
force-pushed
the
feature/cpp
branch
2 times, most recently
from
2d51507 to
ed9766d
Compare
Matthew-Whitlock
force-pushed
the
feature/cpp
branch
from
2fcdd59 to
ad39412
Compare
…nested faults occur
Solves bug when recovering with no spare ranks - no fail_list is allocated, causing segfaults when attempting to use it
Matthew-Whitlock
force-pushed
the
feature/cpp
branch
from
ffc8a9d to
50f0a3f
Compare
Collaborator
Author
|
@saibalde I rebased everything on the develop changes and have merged everything over (I didn't want to pull in the message logging stuff on this branch just to have to fix all the conflicts later). I'll leave this branch alive for now, but we should update KokkosResilience's CI to using Fenix's develop branch (which is the default branch now). The only KR code changes needed should be swapping |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We'll maintain the C interface as well, but this will let us slowly use C++ features internally and also better support C++ application code