Added memory leak checks to travis script

Fixed KLVStream memory leaks (#129)
Fixed misc memory leaks (#130)

.travis.yml

@@ -5,13 +5,15 @@ matrix:
         apt:
           packages:
             - libxerces-c-dev
+            - valgrind
 
       script:
         - mkdir regxmllib/build
         - cd regxmllib/build
         - cmake ..
         - cmake --build .
         - ctest .
+        - ctest -T memcheck .
         - sudo make install
 
     - language: java

regxmllib/CMakeLists.txt

@@ -28,6 +28,8 @@ endforeach()
 
 enable_testing()
 
+include(CTest)
+
 file( GLOB_RECURSE UNIT_TESTS src/test/cpp/*.cpp )
 file(COPY "src/test/resources" DESTINATION "${CMAKE_BINARY_DIR}")
 

regxmllib/CTestConfig.cmake

@@ -0,0 +1 @@
+set(MEMORYCHECK_COMMAND_OPTIONS "--show-leak-kinds=definite --leak-check=full --error-exitcode=1")

regxmllib/src/main/cpp/com/sandflow/smpte/klv/KLVStream.cpp

@@ -102,7 +102,7 @@ namespace rxml {
 			throw std::ios_base::failure("Max BER length exceeded");
 		}
 
-		unsigned char *buf = new unsigned char[bersz];
+		unsigned char buf[8];
 
 		this->read((char*)buf, bersz);
 

regxmllib/src/main/cpp/com/sandflow/smpte/regxml/dict/MetaDictionary.cpp

@@ -95,6 +95,10 @@ namespace rxml {
 					meta_dictionary.subclassesOf[parentauid].insert(def.identification);
 				}
 
+			} else {
+
+				delete def_copy;
+
 			}
 		}
 
@@ -111,19 +115,21 @@ namespace rxml {
 				const AUID parentauid = MetaDictionary::createNormalizedAUID(def.memberOf);
 
 				meta_dictionary.membersOf[parentauid].insert(def.identification);
+
+			} else {
+
+				delete def_copy;
+
 			}
 
 
 		}
 
 
 		virtual void visit(const PropertyAliasDefinition & def) {
-			Definition *def_copy = new PropertyAliasDefinition(def);
-
 			const AUID parentauid = MetaDictionary::createNormalizedAUID(def.memberOf);
 
 			meta_dictionary.membersOf[parentauid].insert(def.identification);
-
 		}
 
 		virtual void visit(const EnumerationTypeDefinition &def) {

regxmllib/src/test/cpp/com/sandflow/smpte/dict/MetaDictionaryTest.cpp

@@ -302,6 +302,7 @@ int main(int argc, char **argv) {
 
 		doc->release();
 
+		delete ft;
 	}
 
 	/* free heap */
@@ -314,7 +315,7 @@ int main(int argc, char **argv) {
 
 	output->release();
 	ser->release();
-
+	delete parser;
 
 	xercesc::XMLPlatformUtils::Terminate();