Skip to content

Support ESM and convert all "functions with prototype" to classes #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

Support ESM and convert all "functions with prototype" to classes #3

wants to merge 20 commits into from

Conversation

pahlers
Copy link

@pahlers pahlers commented Oct 9, 2022

Thanks for all your work. I made two changes to your lib. I hope you like it.

  1. This version supports ESM. ESM is both supported by Nodejs and most browsers.
  2. Convert the "functions with prototype" to classes. Which is less classy, but more modern.

Because I use the browser version, the Nodejs version isn't tested. Sorry.

pahlers added 20 commits October 7, 2022 20:56
@pahlers
feat(import/export): use ES and cleanup
971b14e
@pahlers
fix(usb): Add await
bc8e5e2
@pahlers
fix(usb): Add logging and clean up
3e9c386
@pahlers
fix(RtlSdr): Return promise in resetBuffer
fdb79dc
@pahlers
refactor(RTL2832U): Return into class
6f24a69
@pahlers
refactor(RTL2832U): Return into class
c9ccbd4
@pahlers
refactor(R820T): Return into class
7b22f4c
@pahlers
fix(RTL2832U): Change to use static
957c1d9
@pahlers
refactor(RtlCom): Return into class
367cfd1
@pahlers
fix(RtlCom): Fix sub methods
14aa7c5
@pahlers
fix(RTL2832U): Fix setCenterFrequency
0401918
@pahlers
refactor(RtlSdr): Return into class
d94edc9
@pahlers
refactor(RtlSdr): Return into class
080a6e6
@pahlers
refactor(RtlCom): Boy scout rule
e004b49
@pahlers
refactor(web-usb): Return into class
bd90dae
@pahlers
refactor(usb): Return into class
33c6137
@pahlers
refactor(usb): Add usb classes, needed to start the RtlSdr
3add082
@pahlers
docs(README): Update setup and usage
10402d1
@pahlers
docs(README): Update setup and usage
d9e2b88
@pahlers
feat(package): Update to version v14
d4b659c
@pahlers pahlers changed the title Support ESM and Convert all "functions with prototype" to classes Support ESM and convert all "functions with prototype" to classes Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@pahlers