feat(device) detect new brand Positivo BGH model: Twist S

issue matomo-org#6322
sanchezzzhak · Jun 26, 2020 · b308658 · b308658
1 parent c88c4d2
commit b308658
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 2 deletions.
diff --git a/Tests/fixtures/smartphone-14.yml b/Tests/fixtures/smartphone-14.yml
@@ -7174,4 +7174,24 @@
     model: Twist (2018)
   os_family: Android
   browser_family: Android Browser
+-
+  user_agent: Dalvik/2.1.0 (Linux; U;Android 6.0; Positivo Twist S Build/MRA58K)
+  os:
+    name: Android
+    short_name: AND
+    version: "6.0"
+    platform: ""
+  client:
+    type: browser
+    name: Android Browser
+    short_name: AN
+    version: ""
+    engine: WebKit
+    engine_version: ""
+  device:
+    type: smartphone
+    brand: 3P
+    model: Twist S
+  os_family: Android
+  browser_family: Android Browser
 
diff --git a/regexes/device/mobiles.yml b/regexes/device/mobiles.yml
@@ -14818,8 +14818,10 @@ Multilaser:
 
 # Positivo BGH
 Positivo BGH:
-  regex: '(Twist \(2018\))[);/ ]'
+  regex: '(Positivo Twist S|Twist \(2018\))[);/ ]'
   device: 'smartphone'
   models:
     - regex: 'Twist \(2018\)[);/ ]'
-      model: 'Twist (2018)'
+      model: 'Twist (2018)'
+    - regex: 'Positivo Twist S[);/ ]'
+      model: 'Twist S'