Update insert_sic feature#3
Merged
Merged
Conversation
- Rename insert_sic to restart_mod, char string - Add 'none', 'adjust_aice', and 'adjust_aice_test' restart_mod options - Update documentation, add data assimilation section - Add adjust_aice_test testcase
sanAkel
reviewed
Nov 3, 2025
sanAkel
requested changes
Nov 3, 2025
Owner
sanAkel
left a comment
sanAkel
left a comment
There was a problem hiding this comment.
Following tests passed:
- It built.
- Ran:
- With default, i.e.,
restart_mod:none. - Test:
adjust_aice_test - Real case:
adjust_aice:
Please add a forward slash:
aice_filename = trim(restart_dir)//'/sic.nc'
Without it (i.e., your code as-is) kept looking for a file name with some characters from buffer included, ⬆️ modified code ran fine; see below.
160: (ice_check_nc) No such file or directory, (ice_open_nc) ERROR: Cannot open ./RE
160: START/sic.nc^A^@^@^@^A^@^@^@^A^@^@^@^A^@^@^@^^^B^@^@^@^@^@^@ð^A^@^@^@^@^@^@ ^Z^D^@^@^@^@^@¸¦uÀü^?^@^@^@::üÕ^T^@^@^D^@^@^@^@^@^@^@^@^@^@
160: ^@^@^@^@^@<81>^@^@^@^@^@^@^@^B^@^@^@^@^@^@^@<98><95><86><99>Ô^T^@^@^W^@^@^@^@^@^@^@^D^@^@^@^@^@^@^@^A^@^@^@^@^@^@^@^B^@^@^@^@^@^@^@\^@^@^@^@^@^@^@^A^@^@^@^@^@^@^@<98>v
160: Ø<9f>Ô^T^@^@^H^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@<81>^@^@^@^@^@^@^@^A^@^@^@^@^@^@^@<98><z<99>Ô^T^@^@^E^@^@^@^@^@^@^@ ^Z^D^@^@^@^@^@^A^@^@^@^@^@^@^@Ø^F«<9f>Ô^T^@^@^H
160: ^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@
With the added / in the file name, I got:
(direct_adjust_aice) direct_adjust_aice from ./RESTART//sic.nc
(ice_read_nc_xy) fid= 65536, lnrec = 1, varname = sic
18 tasks
Update rounding to 5/100th from 1/100th. Tested with the standalone gx3 case. One thing that is not tested with the adjust_aice_test option is adding sea ice where there was none originally.
sanAkel
approved these changes
Nov 3, 2025
sanAkel
approved these changes
Nov 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update insert_sic feature