extract alias utils from "helpers" #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ro0gr
commented
Jun 20, 2020
addon-test-support/macros/alias.js
Outdated
| const propOwner = get(object, pathToPropOwner); | ||
|
|
||
| if (propOwner === null || propOwner === undefined) { | ||
| return undefined; |
ro0gr
force-pushed
the
group-alias-utils
branch
3 times, most recently
from
95b63e6
to
1669ca3
Compare
also removed utils tests, since the use cases are covered via alias tests
turns out `objectHasProperty(` has almost implemented a value lookup logic, at the same time, `getProperty(` did almost the same, but via `Ember.get(`. Merging of these 2 methods allows us to get rid of `Ember.get(`, and improve clarity.
ro0gr
force-pushed
the
group-alias-utils
branch
from
1669ca3
to
01aa615
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a part of #512
"helpers.js" is currently polluted with some of single-use utils. Moving such utils to a relevant context shuold imporve code clarity a bit.
Also removed utils tests, since the use cases are covered via alias tests