Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 Fix catalog gallery view #2420

Merged
merged 1 commit into from
Jan 17, 2025
Merged

🧹 Fix catalog gallery view #2420

merged 1 commit into from
Jan 17, 2025

Conversation

kirkkwang
Copy link
Collaborator

Since the Hyrax 5 update the catalog gallery index page had a grid layout of four columns while in default Hyrax has three. Also removed some extra spacing from top row of the items. There was also an extra border that was around the facets that were removed. The description facet on each result has a truncate of 200 characters.

image

Since the Hyrax 5 update the catalog gallery index page had a grid
layout of four columns while in default Hyrax has three.  Also removed
some extra spacing from top row of the items.  There was also an extra
border that was around the facets that were removed.  The description
facet on each result has a truncate of 200 characters.
@kirkkwang kirkkwang added the patch-ver for release notes label Jan 16, 2025
Copy link
Collaborator

@sjproctor sjproctor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link

github-actions bot commented Jan 17, 2025

Test Results

    3 files  ±0      3 suites  ±0   17m 18s ⏱️ -12s
2 055 tests ±0  1 999 ✅ ±0  56 💤 ±0  0 ❌ ±0 
2 082 runs  ±0  2 024 ✅ ±0  58 💤 ±0  0 ❌ ±0 

Results for commit 49651c5. ± Comparison against base commit 92d95f8.

This pull request removes 42 and adds 42 tests. Note that renamed tests count towards both.
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy 680c8d27-21c6-49f6-8404-a0f866c743a1
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit a7329e9e-f089-43cc-ab70-2ca42d0d41eb
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read ff2d3ed2-2372-4b96-9006-6a7a3d3781a0
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update 1d0e266b-f3f1-42a7-80d5-47cb0371260f
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 4c91a987-c073-4b13-80f7-941ce224a542
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit 84ea5ac3-b0a5-4ff0-af4d-a46f17ef6135
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read ee68210c-9e7d-4687-b522-655f8530c850
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update 69509bfb-5318-4d56-ac39-adc69433f035
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy d5670c63-4bd8-4651-a5c8-0d6f5583fa46
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit ac2e8dd0-f085-4641-b224-732d17e5c2f4
…
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy e3636ab5-b47c-4a3b-8967-d5b80cecab91
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit 2c50f4e3-ba33-4357-bead-6ba513994049
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read e85f5149-fc4e-4f90-86a7-ad90490b2701
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update 802b8fee-268d-4684-be4d-91bf52597fb5
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 2708da20-7a3d-4645-a36b-5953c6ee6417
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit 66939745-582c-4b26-a79a-c1503502b1c1
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 7c8072ab-ea69-4993-9f7c-fbe6c8e4baa6
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update 2de599b0-e3a2-4527-8e77-7b1e19ff08cf
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy ef4a19a7-9c38-4b56-b9f5-93d7a3f48971
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit d7b8bd28-719c-4bb9-a118-249b89ebe4e7
…

♻️ This comment has been updated with latest results.

@kirkkwang kirkkwang merged commit 06fe536 into main Jan 17, 2025
8 of 9 checks passed
@kirkkwang kirkkwang deleted the fix-catalog-gallery-view branch January 17, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch-ver for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants