Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homepage fixes #2417

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Homepage fixes #2417

wants to merge 7 commits into from

Conversation

laritakr
Copy link
Collaborator

@laritakr laritakr commented Jan 16, 2025

Fixes notch8/palni_palci_knapsack#142

Fixes homepage footer & dropdown menus

  • Homepage dropdown menus now use site's link colors.
  • Footer now includes both login and log off options to avoid need to override footer.
  • Footer now includes option to add a Privacy Policy link via new (empty) menu partial.
Screenshots

Screenshot 2025-01-14 at 7 34 28 PM

Screenshot 2025-01-14 at 7 35 33 PM

Fixes neutral repository homepage

  • Collections section now has a border
  • Adjusts spacing between sections
  • Makes headings consistent
Screenshot

Screenshot 2025-01-15 at 7 21 43 PM

@laritakr laritakr marked this pull request as draft January 16, 2025 00:16
@laritakr laritakr added the patch-ver for release notes label Jan 16, 2025
Copy link

github-actions bot commented Jan 16, 2025

Test Results

    3 files  ±0      3 suites  ±0   17m 42s ⏱️ -27s
2 055 tests ±0  1 999 ✅ ±0  56 💤 ±0  0 ❌ ±0 
2 082 runs  ±0  2 024 ✅ ±0  58 💤 ±0  0 ❌ ±0 

Results for commit 5823423. ± Comparison against base commit 843705e.

This pull request removes 42 and adds 42 tests. Note that renamed tests count towards both.
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy 7c56ffd7-f068-4501-9dec-696a974d33ee
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit da5c97d9-6b51-4d05-b12e-979fb36af644
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read 237268ed-11d5-421d-92a1-05b0f30180b1
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update a0387adf-f772-41d9-8b95-074bb63f2e31
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 173f47fb-95b9-4d96-a296-812582a726ef
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit 6eb1fb28-ac85-4b64-b1f1-4840b89153a4
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read aced0675-12d1-4126-a59a-b4a3da1116ec
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update f3689d8c-3e03-4bd8-848d-523dc9d4bc1e
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 0418374b-059c-4751-82b2-c56509a3e2ea
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 56ee4da9-346f-435e-bf81-05e7cb2ce869
…
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy d1c06de2-f8fa-4c73-ba76-adf4acc01cb0
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit fab0cd1c-022f-4f60-9712-985507f2eb29
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read 06081124-003b-4ced-a521-d29436c6936d
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update 87fa68e8-a05f-4a87-ace4-3c786e68aba6
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 5a7911fd-6aaa-4290-8055-d4bdad67eef6
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit aa3affdf-433e-4f5a-9515-ee27b10b7f4b
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 057f804a-b60a-4df8-b5cf-79cc243f1107
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update e5caf33e-1232-4830-89e6-5621968ddd43
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 9135ba93-660e-40a6-8494-ebed4a905efe
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit c3b33c22-3a3d-4c98-b83c-0b66d7826ddf
…

♻️ This comment has been updated with latest results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch-ver for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Home Page Themes
1 participant