🧹 Fix ./spec/requests/admin_dashboard_spec.rb spec
#2092
Merged
+17
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, the specs failed because of the introduction of the WorkflowResponsibilityFormDecorator. The decorator extracted prior logic from Hyrax::Admin::WorkflowRolesController. In copying that logic we introduced a subtle bug. Namely, we favored the original `.new` behavior if and only if you provided a `:user_id`. This broke places where we instantiated the form in a view (e.g. `./app/views/hyrax/admin/workflow_roles/index.html.erb`). With this change, we make the behavior of `.new` fail towards its "normal" implementation and instead rely on the presence of an attribute to switch to a different form instantatior. See Commit: - 095edca Related to: - #2079 Co-authored-by: LaRita Robinson <[email protected]> Co-authored-by: Kirk Wang <[email protected]>
kirkkwang
approved these changes
Dec 20, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the specs failed because of the introduction of
the WorkflowResponsibilityFormDecorator. The decorator extracted prior
logic from Hyrax::Admin::WorkflowRolesController.
In copying that logic we introduced a subtle bug. Namely, we favored
the original
.newbehavior if and only if you provided a:user_id.This broke places where we instantiated the form in a
view (e.g.
./app/views/hyrax/admin/workflow_roles/index.html.erb).With this change, we make the behavior of
.newfail towards its"normal" implementation and instead rely on the presence of an attribute
to switch to a different form instantatior.
See Commit:
Related to:
Co-authored-by: LaRita Robinson [email protected]
Co-authored-by: Kirk Wang [email protected]