🧹 Favor Sipity::Entity function over to_sipity_entity #2077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Sipity conversion methods are now explicit functions (much like the `Array()` function). - https://github.com/samvera/hyrax/blob/5aaa568d348a180add2a1337d9d794b740703df8/app/models/sipity.rb#L20
kirkkwang
approved these changes
Dec 19, 2023
orangewolf
reviewed
Dec 19, 2023
There was a problem hiding this comment.
to me, this is stepping backward. having as a method on the object allows the work class to handle the sipity entity in different ways depending on the objects class. if you use this method, the Sipity::Entity has to know about an unknown number to classes. Can you help me understand the api benifit of changing this?
|
@orangewolf Hyrax removed the samvera/hyrax@9f7b2c6 removes this |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Sipity conversion methods are now explicit functions (much like the
Array()function).