Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 Fix inviting existing users failure #2026

Merged
merged 2 commits into from
Oct 16, 2023
Merged

Conversation

jeremyf
Copy link
Contributor

@jeremyf jeremyf commented Oct 16, 2023

Ref

Story

Trying to add a user active in other repositories to another tenant does not return any error but does not add the user.

Changes proposed in this pull request:

  • Always add invited users to the tenant's Registered Users group

Acceptance Criteria

  • Invited users are always added to the Registered Users group

Testing Instructions

  1. Login as a super admin
  2. Create a new tenant (e.g. Tenant A)
  3. Navigate to Tenant A > Dashboard > Manage Users
  4. Invite a new user who does not already exist in the application (i.e. across all tenants, not just one)
  5. Verify that the new user gets added to the Registered Users group in Tenant A
  6. Create a new tenant (e.g. Tenant B)
  7. Navigate to Tenant B > Dashboard > Manage Users
  8. Invite the same user from Step 4. Do not give it any individual roles in the invite form
  9. Verify that the user gets added to the Registered Users group in Tenant B

Notes

The primary issue here is that invited users who already have an account (i.e. an instance of User in the database) were not being added to the tenant's Registered Users group. This meant that, if a user was invited with no specific roles, they simply wouldn't show up in the tenant at all.

@samvera/hyku-code-reviewers

Fixes a bug where users who were invited with no roles would not
show up in the users list at all
@jeremyf jeremyf added the patch-ver for release notes label Oct 16, 2023
@jeremyf jeremyf merged commit d2c02e3 into adventist_dev Oct 16, 2023
1 of 2 checks passed
@jeremyf jeremyf deleted the backport-2025 branch October 16, 2023 13:40
@kirkkwang kirkkwang mentioned this pull request Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch-ver for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants