Merge pull request #2071 from samvera/i55-get-specs-passing

More spec fixes
samvera · Dec 19, 2023 · 5159b57 · 5159b57
2 parents ac83919 + e905068
commit 5159b57
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb
@@ -26,6 +26,7 @@ def locale_for(type:, term:, record_class:)
   end
 
   def missing_translation(value, _options = {})
-    value.include?('translation missing')
+    return true if value.try(:false?)
+    false
   end
 end
diff --git a/spec/presenters/hyku/menu_presenter_spec.rb b/spec/presenters/hyku/menu_presenter_spec.rb
@@ -125,7 +125,7 @@
     let(:id) { "sample_id" }
     let(:icon_class) { "sample-icon-class" }
     let(:open) { true }
-    let(:html_options) { { class: "sample-class", data: { test: "test" } } }
+    let(:title) { "Cats" }
     let(:block) { proc { "<li>Item</li>" } }
 
     let(:presenter) { instance_double("CollapsableSectionPresenter") }
@@ -137,13 +137,13 @@
         id:,
         icon_class:,
         open:,
-        html_options:
+        title:
       ).and_return(presenter)
     end
 
     it "calls the render method on the CollapsableSectionPresenter with the given block" do
       expect(presenter).to receive(:render)
-      instance.collapsable_section(text, id:, icon_class:, open:, **html_options, &block)
+      instance.collapsable_section(text, id:, icon_class:, open:, title:, &block)
     end
   end
 end