Skip to content

Commit

Permalink
🐛 Fix some javascript errors
Browse files Browse the repository at this point in the history
This commit will fix a few javascript errors, at least enough to get the
the bootstrap javascript to work correctly.  We're still getting a the
almond-rails js error but that seems to exist in previous Hyku as well.
  • Loading branch information
kirkkwang committed Dec 18, 2023
1 parent 7254e9f commit 0d76532
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 3 deletions.
1 change: 1 addition & 0 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ gem 'spring-watcher-listen', '~> 2.0.0', group: %i[development]
gem 'terser' # to support the Safe Navigation / Optional Chaining operator (?.) and avoid uglifier precompile issue
gem 'tether-rails'
gem 'turbolinks', '~> 5'
gem 'twitter-typeahead-rails', '0.11.1.pre.corejavascript'
gem 'web-console', '>= 3.3.0', group: %i[development] # <%= console %> in views
gem 'webdrivers', '~> 4.7.0', group: %i[test]
gem 'webmock', group: %i[test]
Expand Down
5 changes: 5 additions & 0 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -1295,6 +1295,10 @@ GEM
turbolinks (5.2.1)
turbolinks-source (~> 5.2)
turbolinks-source (5.2.0)
twitter-typeahead-rails (0.11.1.pre.corejavascript)
actionpack (>= 3.1)
jquery-rails
railties (>= 3.1)
typhoeus (1.4.1)
ethon (>= 0.9.0)
tzinfo (2.0.6)
Expand Down Expand Up @@ -1459,6 +1463,7 @@ DEPENDENCIES
terser
tether-rails
turbolinks (~> 5)
twitter-typeahead-rails (= 0.11.1.pre.corejavascript)
web-console (>= 3.3.0)
webdrivers (~> 4.7.0)
webmock
Expand Down
9 changes: 6 additions & 3 deletions app/assets/javascripts/application.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,10 @@
// Read Sprockets README (https://github.com/rails/sprockets#sprockets-directives) for details
// about supported directives.
//
//= require codemirror
//= require codemirror-autorefresh
//= require codemirror/modes/css
//= require jquery3
//= require rails-ujs
//= require popper
//= require twitter/typeahead
//= require bootstrap
//= require jquery.fontselect
//= require jquery.dataTables
Expand Down Expand Up @@ -47,6 +45,11 @@
//= require bulkrax/application

//= require hyrax

//= require codemirror
//= require codemirror-autorefresh
//= require codemirror/modes/css

//= require iiif_print

//= require jquery.flot.pie
Expand Down

0 comments on commit 0d76532

Please sign in to comment.