Remove font-awesome references #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As far as we can tell, browse-everything was not using font-awesome at all. Removing the dependency and references makes the code simpler, less likely to cause dependency conflicts, and generally easier to deal with other subsequent changes. Technical backwards incompat unlikely to effect many/any: * If apps were counting on using font-awesome via the rails gem, but were not otherwise declaring it as a dependency, relying on b-e to include the ruby gem or provide the '@import' in a generated file — they’ll have to do these things themselves. * There is no longer a ‘fa3’ or ‘fa4’ class added to the BE HTML. Unlikely to effect anyone unless they had overridden BE HHTML in weird ways; BE itself was not providing any styling making use of these classes.
|
I'm OK with the first bullet point – dependencies aren't part of our contract with the consumer. The second point seems really unlikely to bite anyone. I'll approve and merge right after the new test run passes. |
jrgriffiniii
approved these changes
Nov 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as we can tell, browse-everything was not using font-awesome at all. Removing the dependency and references makes the code simpler, less likely to cause dependency conflicts, avoid adding weight for an unused dependency, and generally easier to deal with other subsequent changes.
Technical backwards incompat unlikely to effect many/any:
If apps were counting on using font-awesome via the rails gem, but were not otherwise declaring it as a dependency, relying on b-e to include the ruby gem or provide the '@import' in a generated file — they’ll have to do these things themselves.
There is no longer a ‘fa3’ or ‘fa4’ class added to the BE HTML. Unlikely to effect anyone unless they had overridden BE HTML in weird ways; BE itself was not providing any styling making use of these classes.
Ref #246