Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove redundant wheel requirement from pyproject.toml #126

Merged
merged 1 commit into from
Apr 28, 2022

Conversation

mgorny
Copy link
Contributor

@mgorny mgorny commented Apr 23, 2022

Remove the dependency on wheel from pyproject.toml. It was never
required, and modern setuptools documentation advises against it.

Remove the dependency on `wheel` from `pyproject.toml`.  It was never
required, and modern setuptools documentation advises against it.
@codecov
Copy link

codecov bot commented Apr 23, 2022

Codecov Report

Merging #126 (ec0e6fc) into main (257747b) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #126   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          373       373           
  Branches        79        79           
=========================================
  Hits           373       373           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 257747b...ec0e6fc. Read the comment docs.

@samuelcolvin samuelcolvin merged commit bd44ff0 into samuelcolvin:main Apr 28, 2022
@samuelcolvin
Copy link
Owner

thanks.

@mgorny
Copy link
Contributor Author

mgorny commented Apr 28, 2022

Thanks for merging!

@samuelcolvin
Copy link
Owner

Is there a link to this advice? In some cases it does seem to be required, or at least avoid warnings when installing locally.

@mgorny
Copy link
Contributor Author

mgorny commented May 1, 2022

The documentation for declaring build-system is here: https://setuptools.pypa.io/en/latest/build_meta.html#how-to-use-it

Particularly note:

The setuptools package implements the build_sdist command and the wheel package implements the build_wheel command; the latter is a dependency of the former exposed via PEP 517 hooks.

i.e. you say that your project needs setuptools, then setuptools.build_meta says it needs wheel.

The commit correcting the docs is pypa/setuptools@f7d30a9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants