-
-
Notifications
You must be signed in to change notification settings - Fork 44
Make datetime tests pass without requiring UTC system timezone #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
samuelcolvin
merged 7 commits into
samuelcolvin:main
from
alexmojaki:fix-datetime-utc-tests
Nov 14, 2023
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
cd4600d
Make datetime tests pass without requiring UTC system timezone
alexmojaki 249435b
Pass absolute paths to find_examples so that tests don't rely on cwd
alexmojaki 6bb7f1a
Use same version of platformdirs in all requirements/*.txt files
alexmojaki b3b6ba0
revert changes to datetime and test_datetime
alexmojaki 700f68e
set TZ=utc in make test since some tests require it
alexmojaki 76350ee
test examples before linting
alexmojaki da631fc
update pytest-examples, so conversion to str isn't needed
alexmojaki File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,25 +1,33 @@ | ||
| import platform | ||
| from pathlib import Path | ||
|
|
||
| import pytest | ||
| from pytest_examples import CodeExample, EvalExample, find_examples | ||
|
|
||
| root_dir = Path(__file__).parent.parent | ||
|
|
||
| examples = find_examples( | ||
| root_dir / 'dirty_equals', | ||
| root_dir / 'docs', | ||
| ) | ||
|
|
||
|
|
||
| @pytest.mark.skipif(platform.python_implementation() == 'PyPy', reason='PyPy does not allow metaclass dunder methods') | ||
| @pytest.mark.parametrize('example', find_examples('dirty_equals', 'docs'), ids=str) | ||
| @pytest.mark.parametrize('example', examples, ids=str) | ||
| def test_docstrings(example: CodeExample, eval_example: EvalExample): | ||
| prefix_settings = example.prefix_settings() | ||
| # E711 and E712 refer to `== True` and `== None` and need to be ignored | ||
| # I001 refers is a problem with black and ruff disagreeing about blank lines :shrug: | ||
| eval_example.set_config(ruff_ignore=['E711', 'E712', 'I001']) | ||
|
|
||
| if prefix_settings.get('lint') != 'skip': | ||
| if eval_example.update_examples: | ||
| eval_example.format(example) | ||
| else: | ||
| eval_example.lint(example) | ||
|
|
||
| if prefix_settings.get('test') != 'skip': | ||
| if eval_example.update_examples: | ||
| eval_example.run_print_update(example) | ||
| else: | ||
| eval_example.run_print_check(example) | ||
|
|
||
| if prefix_settings.get('lint') != 'skip': | ||
| if eval_example.update_examples: | ||
| eval_example.format(example) | ||
| else: | ||
| eval_example.lint(example) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.