Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Authentication untuk operasi melibatkan API #7

Merged
merged 11 commits into from
Aug 12, 2022
Merged

Feature: Authentication untuk operasi melibatkan API #7

merged 11 commits into from
Aug 12, 2022

Conversation

AbizarLeman
Copy link

@AbizarLeman AbizarLeman commented Aug 5, 2022 •
edited
Loading

Berkaitan dengan isu #2 , berikut beberapa tambahan yang telah diterapkan:

  • Penerapan JWT authentication, serta pakej-pakej baharu.
  • Model 'User' untuk kegunaan authentication.
  • Operasi-operasi CRUD yang berkaitan dengan 'User'.
  • Kes-kes ujian baharu.

Saya sangat mengalu-alukan nasihat untuk penambahbaikan PR atau gaya pengaturcaraan, terima kasih.

Thaza-Kun
Thaza-Kun reviewed Aug 6, 2022
View reviewed changes
Copy link
Collaborator

@Thaza-Kun Thaza-Kun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Secara fungsinya dah ok. Tapi perlu perkemaskan penulisan ikut yang saya dah komen.

pyproject.toml Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
samudra/core/crud/user.py Outdated Show resolved Hide resolved
samudra/models/user.py Outdated Show resolved Hide resolved
samudra/schemas/tables/user.py Outdated Show resolved Hide resolved
samudra/server/routes/authentication.py Outdated Show resolved Hide resolved
tests/test_crud.py Outdated Show resolved Hide resolved
@Thaza-Kun Thaza-Kun linked an issue Aug 6, 2022 that may be closed by this pull request
Tambah Authentication untuk operasi melibatkan API #2
Closed
@Thaza-Kun Thaza-Kun removed a link to an issue Aug 6, 2022
Tambah Authentication untuk operasi melibatkan API #2
Closed
@Thaza-Kun Thaza-Kun linked an issue Aug 6, 2022 that may be closed by this pull request
Tambah Authentication untuk operasi melibatkan API #2
Closed
@AbizarLeman AbizarLeman requested a review from Thaza-Kun August 8, 2022 14:16
Thaza-Kun
Thaza-Kun approved these changes Aug 12, 2022
View reviewed changes
Copy link
Collaborator

@Thaza-Kun Thaza-Kun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Baiklah. Nampak ok. Kita merge masuk.

pyproject.toml Show resolved Hide resolved
@Thaza-Kun Thaza-Kun merged commit 37283e4 into samudradev:master Aug 12, 2022
@AbizarLeman
Copy link
Author

Baik. Terima kasih atas maklum balas.

@Thaza-Kun
Copy link
Collaborator

Dah selesaikan masalah dengan poetry install --extras mysql dalam 61398b7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thaza-Kun Thaza-Kun Thaza-Kun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tambah Authentication untuk operasi melibatkan API
2 participants
@AbizarLeman @Thaza-Kun