More Form Enhancements #138
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit enhances audio form with the ability to disable deletion of text as well as configure clipboard operations'. 1. A new enum `clipboard_flags`: We now have a new enum that offers 3 constants: `clipboard_flag_copy, clipboard_flag_cut_clipboard_paste`. This is internal, and the users don't need to use this. 2. 2 new methods for configuring whether or not you want to allow the users to use backspace or delete keys. a. `bool audio_form::set_enable_delete(int control_index, bool enabled);` b. `bool audio_form::set_delete_disabled_message(int control_index, string mesage);` 3. A new method for setting clipboard_flags: `bool audio_form::set_clipboard_flags(control_index, bool copy, bool cut, bool paste);`
harrymkt
reviewed
Nov 10, 2024
release/include/form.nvgt
Outdated
| paste_text(); | ||
| if (key_repeating(KEY_BACK)) { | ||
| if ((key_down(KEY_LCTRL) || key_down(KEY_RCTRL)) && (sel_start < 0 || sel_end < 0 || sel_start > sel_end)) { | ||
| if (false == enable_delete) { |
There was a problem hiding this comment.
Suggested change
| if (false == enable_delete) { | |
| if (!enable_delete) { |
harrymkt
reviewed
Nov 10, 2024
| paste_text(); | ||
| if (key_repeating(KEY_BACK)) { | ||
| if ((key_down(KEY_LCTRL) || key_down(KEY_RCTRL)) && (sel_start < 0 || sel_end < 0 || sel_start > sel_end)) { | ||
| if (false == enable_delete) { | ||
| speak(delete_disabled_message); |
There was a problem hiding this comment.
Suggested change
| speak(delete_disabled_message); | |
| if (delete_disabled_message != "") speak(delete_disabled_message); |
harrymkt
reviewed
Nov 10, 2024
release/include/form.nvgt
Outdated
| delete_word_left(); | ||
| return; | ||
| } | ||
| delete_highlighted(); | ||
| } | ||
| if (key_repeating(KEY_DELETE)) { | ||
| if ((key_down(KEY_LCTRL) || key_down(KEY_RCTRL)) && (sel_start < 0 || sel_end < 0 || sel_start > sel_end)) { | ||
| if (false == enable_delete) { |
There was a problem hiding this comment.
Suggested change
| if (false == enable_delete) { | |
| if (!enable_delete) { |
harrymkt
reviewed
Nov 10, 2024
| delete_word_left(); | ||
| return; | ||
| } | ||
| delete_highlighted(); | ||
| } | ||
| if (key_repeating(KEY_DELETE)) { | ||
| if ((key_down(KEY_LCTRL) || key_down(KEY_RCTRL)) && (sel_start < 0 || sel_end < 0 || sel_start > sel_end)) { | ||
| if (false == enable_delete) { | ||
| speak(delete_disabled_message); |
There was a problem hiding this comment.
Suggested change
| speak(delete_disabled_message); | |
| if (delete_disabled_message != "") speak(delete_disabled_message); |
THis commit adds a new method to the audio form. You can now set readonly attribute after creating a control.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit enhances audio form with the ability to disable deletion of text as well as configure clipboard operations'.
A new enum
clipboard_flags: We now have a new enum that offers 3 constants:clipboard_flag_copy, clipboard_flag_cut_clipboard_paste. This is internal, and the users don't need to use this.2 new methods for configuring whether or not you want to allow the users to use backspace or delete keys. a.
bool audio_form::set_enable_delete(int control_index, bool enabled);b.bool audio_form::set_delete_disabled_message(int control_index, string mesage);A new method for setting clipboard_flags:
bool audio_form::set_clipboard_flags(control_index, bool copy, bool cut, bool paste);