Utility methods on CloseableIterator to make life a little easier. #589
Conversation
|
|
||
| /** Returns a Stream that will consume from the underlying iterator. */ | ||
| default Stream<T> stream() { | ||
| final Spliterator<T> s = Spliterators.spliteratorUnknownSize(this, Spliterator.ORDERED); |
There was a problem hiding this comment.
@tfenne Is there any way that we can set it up so the iterator is automatically closed when the stream is consumed?
There was a problem hiding this comment.
I agree it would be nice, but I'm not sure how possible it is without a bunch of wrapper-ing of the iterators. Let me see if I can come up with something that's not too ugly.
There was a problem hiding this comment.
I don't see an easy way unless stream offers some sort of on-closed callback... I was hoping you'd know some magic...
There was a problem hiding this comment.
Ahah, there is exactly such a method. Stream.onClose(Runnable)
There was a problem hiding this comment.
Yup - I just found that too. Updated to use it.
|
@lbergelson Changes are all made, can you take a quick final look please? |
|
👍 Thanks for this. I definitely seem myself using the stream function in the future. Merge when ready. |
Description
Scala has spoiled me, and I'm tired of Java's iterators being second class citizens. This commit adds a pair of default methods to
CloseableIteratorwhich will benefit most iterators in htsjdk, and allows easy transformation to aListand aStream.Checklist