Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a URLHelper factory API to ParsingUtils #1421

Merged
merged 5 commits into from
Oct 11, 2019
Merged

Add a URLHelper factory API to ParsingUtils #1421

merged 5 commits into from
Oct 11, 2019

Commits on Oct 3, 2019

  1. Add a URLHelper factory API to ParsingUtils -- this is a replacement … 

    …for the previous implementation which used reflection to accomplish the same thing. Reflection won't work for Java 11 clients, its illegal across module boundaries for the most part, and bad practice as well. The reflection API was left in place in case anyone is using it with Java 8.
    @jrobinso
    jrobinso committed Oct 3, 2019
    Configuration menu
    Copy the full SHA
    9b63628 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2019

  1. Updates to PR based on comments 

    * More javadoc
* Remove old reflection-based code and global
* add getter for helper factory
    @jrobinso
    jrobinso committed Oct 11, 2019
    Configuration menu
    Copy the full SHA
    d84e083 View commit details
    Browse the repository at this point in the history

  2. update comment

    @jrobinso
    jrobinso committed Oct 11, 2019
    Configuration menu
    Copy the full SHA
    05dd043 View commit details
    Browse the repository at this point in the history

  3. Update comment

    @jrobinso
    jrobinso committed Oct 11, 2019
    Configuration menu
    Copy the full SHA
    eec9348 View commit details
    Browse the repository at this point in the history

  4. Update PR based on comments 

    * default method in URLHelperFactory interface is removed
* update some comments
    @jrobinso
    jrobinso committed Oct 11, 2019
    Configuration menu
    Copy the full SHA
    6090ee9 View commit details
    Browse the repository at this point in the history