Fixing bad behavior in IOUtil.deletePaths #1416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The method IOUtil.deletePaths(Iterable<Path>) had pathological.
* A Path is an Iterable<Path> which iterates over the subpaths in the Path.
Therefore, this version was binding instead of the varargs version that takes Path...
Then the method would try to delete all of the subpaths in the path.
* This is obviously bad behavior. Fixed by adding an explicit check to see if it's called with a single Path.
* Extracted a new method deletePath which is used for deleting a single path.
* Fixes ##1414
Codecov Report
@@ Coverage Diff @@
## master #1416 +/- ##
===============================================
+ Coverage 68.124% 68.127% +0.003%
- Complexity 8379 8381 +2
===============================================
Files 573 573
Lines 33982 33985 +3
Branches 5668 5668
===============================================
+ Hits 23150 23153 +3
Misses 8643 8643
Partials 2189 2189
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method
IOUtil.deletePaths(Iterable<Path>)had pathological behavior.Pathis anIterable<Path>which iterates over the subpaths in the Path.Therefore, this version was binding instead of the varargs version that takes
Path...Then the method would try to delete all of the subpaths in the path which doesn't delete the intended target and could delete random files.
deletePathwhich is used for deleting a single path.Fixes #DiskBackedQueue closeIOResources is broken #1414