Addresses part of issue #18, Allele class refactoring. #1370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More concretely it refactor the Allele class: * Is now and interface. * Added several methods to access properties from several allele types like breakends and whole contig insertions. * Disentagles the current mixture of "display" bytes vs base bytes in the bases array... now only base are stored like that if it applies. * Adds a "hidden" heriarchy of implementations for different allele subtypes. * Improves reusing instances for common variants (single base and common symbolic alleles) * Mark as deprecated several method that seem unecessary. * Disable the possibility of changing an allele bases and adds an API (BaseSequence interface) to access these efficiently wihtout the need of clonning a byte[] array each time. * Makes impossible to create alleles that have invalid base (IUPAC codes that are not allowed by the VCF spec). * Fixes (and also deprecates) some not well-though Allele method that only make sense for some subtypes of alleles. * Breakend API, access to contig, position type of breakend and base.
vruano
changed the title
|
Allele.java diffs rather messy perhaps reviewers should consider to assess it on the changed version of the file and go back to the github diff just report what they don't like. |
|
Current test pass but need to add new ones, please review in the meantime. |
|
I'm adding test code and fixing issues in the code as I come across them, you can start reviewing the first commit only for stability. |
vruano
commented
May 28, 2019
| /** | ||
| * Enumeration of possible allele types/categories. | ||
| */ | ||
| public enum AlleleType { |
There was a problem hiding this comment.
Oups this class is actually not in use. I forgot to delete it I guess. Is not much point to it as 99.9% of the time code only know how to deal with one type so call to the corresponding isBlahBlah() method is sufficient. You can ignore this class in your review(s)
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More concretely it refactor the Allele class:
wihtout the need of cloning a byte[] array each time.
Description
Please explain the changes you made here.
Explain the motivation for making this change. What existing problem does the pull request solve?
Checklist