Added name of offending record to error message in SamPairUtil #1358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apologies about the CRLF->LF change. please use "hide whitespaces" to view the actual code change. |
Codecov Report
@@ Coverage Diff @@
## master #1358 +/- ##
===============================================
+ Coverage 67.849% 68.024% +0.174%
- Complexity 8283 8363 +80
===============================================
Files 563 563
Lines 33707 33994 +287
Branches 5657 5720 +63
===============================================
+ Hits 22870 23124 +254
- Misses 8659 8687 +28
- Partials 2178 2183 +5
|
cmnbroad
approved these changes
May 6, 2019
| // No need to advance if we have records remaining | ||
| if (!records.isEmpty()) return; | ||
|
|
||
| /* |
There was a problem hiding this comment.
Multi-line comments usually have a * character at the start of each line. Or, you could use // for each line of a multi-line comment.
Can you make another PR that doesn't show every line as being different? Nevermind, I see you updated from DOS->Unix.
pshapiro4broad
approved these changes
May 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was inspired by broadinstitute/picard#201 where the error doesn't allow the user to investigate the offending record. By adding the record name to the exception message, the user can investigate more easily and fix the input.