-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support writing a CRAI index from CRAMContainerStreamWriter #1351
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1351 +/- ##
===============================================
+ Coverage 67.848% 67.861% +0.013%
- Complexity 8283 8286 +3
===============================================
Files 563 563
Lines 33706 33710 +4
Branches 5657 5656 -1
===============================================
+ Hits 22869 22876 +7
+ Misses 8659 8657 -2
+ Partials 2178 2177 -1
|
cc @cmnbroad |
src/test/java/htsjdk/samtools/CRAMContainerStreamWriterTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx for making the common class/interface. Looks pretty good - just a request to factor out some duplicated test code.
src/test/java/htsjdk/samtools/CRAMContainerStreamWriterTest.java
Outdated
Show resolved
Hide resolved
src/test/java/htsjdk/samtools/CRAMContainerStreamWriterTest.java
Outdated
Show resolved
Hide resolved
src/test/java/htsjdk/samtools/CRAMContainerStreamWriterTest.java
Outdated
Show resolved
Hide resolved
Thanks for all the feedback @pshapiro4broad and @cmnbroad. I've addressed all the points in a new commit. |
Description
This is to make it possible to write CRAI indexes from
CRAMContainerStreamWriter
, not just BAI indexes (as is the case currently). This is needed by disq-bio/disq#97.This PR introduces
AbstractCRAMIndexer
that is the common base class ofCRAMBAIIndexer
andCRAMCRAIIndexer
; and adds a constructor toCRAMContainerStreamWriter
that takes anAbstractCRAMIndexer
.Checklist