SortingCollection logging should only be if DEBUG #1334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1334 +/- ##
===========================================
Coverage 67.822% 67.822%
Complexity 8253 8253
===========================================
Files 562 562
Lines 33644 33644
Branches 5640 5640
===========================================
Hits 22818 22818
Misses 8654 8654
Partials 2172 2172
|
lbergelson
approved these changes
Mar 20, 2019
|
No objections here. |
|
@alecw Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A utility like SortingCollection should not fill log output with unnecessary output by default. Caller can enable debug output if they want to see these messages. We sometimes create a lot of SortingCollections, and these messages become annoying.
Checklist