Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix signing task in build.gradle #1325

Merged
merged 1 commit into from
Mar 18, 2019
Merged

Fix signing task in build.gradle #1325

merged 1 commit into from
Mar 18, 2019

Conversation

lbergelson
Copy link
Member

  • Fix the signing task configuration in build.gradle so that releases are signed.
    I had to do this for the 2.19.0 release.

Checklist

  • Code compiles correctly
  • New tests covering changes and new functionality
  • All tests passing
  • Extended the README / documentation, if necessary
  • Is not backward compatible (breaks binary or source compatibility)

* Fix the signing task configuration in build.gradle so that releases are signed.
Copy link
Collaborator

@cmnbroad cmnbroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine as far as I can tell.

@codecov-io
Copy link

codecov-io commented Mar 13, 2019

Codecov Report

Merging #1325 into master will increase coverage by 0.037%.
The diff coverage is n/a.

@@              Coverage Diff               @@
##              master    #1325       +/-   ##
==============================================
+ Coverage     67.793%   67.83%   +0.037%     
- Complexity      8251     8268       +17     
==============================================
  Files            562      562               
  Lines          33639    33699       +60     
  Branches        5641     5667       +26     
==============================================
+ Hits           22805    22858       +53     
+ Misses          8659     8658        -1     
- Partials        2175     2183        +8
Impacted Files Coverage Δ Complexity Δ
src/main/java/htsjdk/variant/bcf2/BCF2Codec.java 78.947% <0%> (+1.566%) 51% <0%> (+16%) ⬆️
...samtools/util/AsyncBlockCompressedInputStream.java 76% <0%> (+4%) 13% <0%> (+1%) ⬆️

@lbergelson lbergelson merged commit 5dcfd73 into master Mar 18, 2019
@lbergelson lbergelson deleted the lb_fix_signing branch March 18, 2019 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants