Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding back a removed method #1321

Merged
merged 1 commit into from
Mar 12, 2019
Merged

Adding back a removed method #1321

merged 1 commit into from
Mar 12, 2019

Conversation

lbergelson
Copy link
Member

  • Adding back an accidentally removed an overload of IntervalList.getUniqueIntervals().
  • This fixes a compatibility problem revealed in the pre-release checks.

Checklist

  • Code compiles correctly
  • New tests covering changes and new functionality
  • All tests passing
  • Extended the README / documentation, if necessary
  • Is not backward compatible (breaks binary or source compatibility)

* Adding back an accidentally removed an overload of IntervalList.getUniqueIntervals().
* This fixes a compatibility problem revealed in the pre-release checks.
@lbergelson
Copy link
Member Author

@yfarjoun I missed this in review. Compatibility checker caught it...

@codecov-io
Copy link

Codecov Report

Merging #1321 into master will increase coverage by 0.007%.
The diff coverage is 0%.

@@               Coverage Diff               @@
##              master     #1321       +/-   ##
===============================================
+ Coverage     67.626%   67.633%   +0.007%     
- Complexity      8229      8230        +1     
===============================================
  Files            562       562               
  Lines          33617     33618        +1     
  Branches        5642      5642               
===============================================
+ Hits           22734     22737        +3     
+ Misses          8708      8707        -1     
+ Partials        2175      2174        -1
Impacted Files Coverage Δ Complexity Δ
...c/main/java/htsjdk/samtools/util/IntervalList.java 74.51% <0%> (-0.244%) 75 <0> (ø)
...samtools/util/AsyncBlockCompressedInputStream.java 76% <0%> (+4%) 13% <0%> (+1%) ⬆️

1 similar comment
@codecov-io
Copy link

codecov-io commented Mar 11, 2019

Codecov Report

Merging #1321 into master will increase coverage by 0.007%.
The diff coverage is 0%.

@@               Coverage Diff               @@
##              master     #1321       +/-   ##
===============================================
+ Coverage     67.626%   67.633%   +0.007%     
- Complexity      8229      8230        +1     
===============================================
  Files            562       562               
  Lines          33617     33618        +1     
  Branches        5642      5642               
===============================================
+ Hits           22734     22737        +3     
+ Misses          8708      8707        -1     
+ Partials        2175      2174        -1
Impacted Files Coverage Δ Complexity Δ
...c/main/java/htsjdk/samtools/util/IntervalList.java 74.51% <0%> (-0.244%) 75 <0> (ø)
...samtools/util/AsyncBlockCompressedInputStream.java 76% <0%> (+4%) 13% <0%> (+1%) ⬆️

Copy link
Contributor

@yfarjoun yfarjoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

odd....thanks!

@lbergelson lbergelson merged commit 019465f into master Mar 12, 2019
@lbergelson lbergelson deleted the lb_re_add_deleted_method branch March 13, 2019 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants