Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update java version information in the README #1299

Merged
merged 2 commits into from
Feb 21, 2019

Conversation

lbergelson
Copy link
Member

@lbergelson lbergelson commented Feb 20, 2019

Description

The readme had inaccurate information about which versions we support.

Checklist

  • Code compiles correctly
  • New tests covering changes and new functionality
  • All tests passing
  • Extended the README / documentation, if necessary
  • Is not backward compatible (breaks binary or source compatibility)

@codecov-io
Copy link

codecov-io commented Feb 20, 2019

Codecov Report

Merging #1299 into master will decrease coverage by 0.009%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##              master     #1299       +/-   ##
===============================================
- Coverage     67.622%   67.613%   -0.009%     
+ Complexity      8176      8175        -1     
===============================================
  Files            560       560               
  Lines          33424     33424               
  Branches        5632      5632               
===============================================
- Hits           22602     22599        -3     
- Misses          8639      8641        +2     
- Partials        2183      2184        +1
Impacted Files Coverage Δ Complexity Δ
src/main/java/htsjdk/samtools/BAMFileReader.java 67.847% <0%> (-0.817%) 51% <0%> (-1%)

Copy link
Contributor

@yfarjoun yfarjoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typos

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@lbergelson
Copy link
Member Author

@yfarjoun Thank you.

@lbergelson lbergelson merged commit 5e8b1fa into master Feb 21, 2019
@lbergelson lbergelson deleted the lb_update_java_support_readme branch February 21, 2019 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants