Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant and unused BAM_FLAGS from CRAM code. #1292

Merged
merged 1 commit into from
Feb 20, 2019

Conversation

cmnbroad
Copy link
Collaborator

@cmnbroad cmnbroad commented Feb 19, 2019

Minor cleanup/removal of unused of code I noticed during a code review.

@codecov-io
Copy link

codecov-io commented Feb 19, 2019

Codecov Report

Merging #1292 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@              Coverage Diff               @@
##              master     #1292      +/-   ##
==============================================
+ Coverage     67.495%   67.505%   +0.01%     
  Complexity      8150      8150              
==============================================
  Files            558       558              
  Lines          33364     33359       -5     
  Branches        5608      5606       -2     
==============================================
  Hits           22519     22519              
+ Misses          8657      8652       -5     
  Partials        2188      2188
Impacted Files Coverage Δ Complexity Δ
...samtools/cram/structure/CramCompressionRecord.java 82.609% <ø> (+3.442%) 88 <0> (ø) ⬇️

Copy link
Member

@lbergelson lbergelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@lbergelson lbergelson merged commit efe4abf into samtools:master Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants