Fixes for issues found by SpotBugs #1283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1283 +/- ##
===============================================
+ Coverage 67.495% 67.501% +0.006%
+ Complexity 8150 8149 -1
===============================================
Files 558 557 -1
Lines 33364 33352 -12
Branches 5608 5607 -1
===============================================
- Hits 22519 22513 -6
+ Misses 8657 8651 -6
Partials 2188 2188
|
jmthibault79
commented
Feb 14, 2019
jmthibault79
commented
Feb 14, 2019
cmnbroad
requested changes
Feb 14, 2019
cmnbroad
approved these changes
Feb 20, 2019
rm ExternalBlock class, add static factory method - resolves use of initialized value found by SpotBugs rm unused nextRecord nextRecord -> samRecord basic content ID check test createRawNonExternalBlock and more tests enableFileSourceTest revert CRAMFileReaderTest BlockTest to Block package Update src/test/java/htsjdk/samtools/cram/structure/BlockTest.java Co-Authored-By: jmthibault79 <[email protected]>
jmthibault79
force-pushed
the
jt_spotbugs
branch
from
e1dbbec
to
71aee8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #1279 - removed the ExternalBlock class which was not truly necessary
Resolves #1280 - removed the unused
CramIterator.nextRecordfieldResolves #1281 - removed the unused
CramHeader.clone()methodChecklist