Moving the SRA tests to a separate env #1272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
February 2, 2019 12:41
This comment has been minimized.
This comment has been minimized.
|
This should fix the breakage of the master branch. |
lbergelson
reviewed
Feb 5, 2019
| @@ -7,6 +7,8 @@ | |||
|
|
|||
| import java.io.IOException; | |||
|
|
|||
| //calling this an FTP test so that it could fail in travis | |||
| @Test(groups="ftp") | |||
| public class EnaRefServiceTest extends HtsjdkTest { | |||
There was a problem hiding this comment.
I don't like labelling this as an FTP test. Maybe instead of a new SRA block we can have an EXTERNAL_APIS test type that covers SRA and ENA.
lbergelson
requested changes
Feb 5, 2019
There was a problem hiding this comment.
@yfarjoun I think it's a good idea to group the ENA and SRA tests together if they're likely to fail together. Gross to have the ENA server test in FTP since that's just broken forever and has to be removed while the ENA test is potentially valuable.
lbergelson
reviewed
Feb 5, 2019
lbergelson
approved these changes
Feb 5, 2019
There was a problem hiding this comment.
@yfarjoun One typo and then 👍 Thanks for doing this while I was incommunicado.
Co-Authored-By: yfarjoun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please explain the changes you made here.
Explain the motivation for making this change. What existing problem does the pull request solve?
Checklist