-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test on Java 11 #1269
Test on Java 11 #1269
Conversation
did you only open this to get the tests? is this a serious candidate for merging? in the current state, of course that would not be possible... |
Codecov Report
@@ Coverage Diff @@
## master #1269 +/- ##
===============================================
- Coverage 69.358% 67.515% -1.843%
+ Complexity 8302 8151 -151
===============================================
Files 555 558 +3
Lines 33118 33397 +279
Branches 5572 5632 +60
===============================================
- Hits 22970 22548 -422
- Misses 7886 8665 +779
+ Partials 2262 2184 -78
|
@yfarjoun the goal here is to check we can build and run htsjdk tests with Java 11. The source and target Java versions are not changed - they are still Java 8 - so this is just to ensure that we can use a Java 11 compiler and runtime with the current htsjdk source. It does not replace the Java 8-based build. There were a few things I had to change to get this to work:
This is a serious candidate for merging, since none of these changes interfere with the current Java 8 build. I also added a |
Wow, those two javadoc comments were the issue? I assumed it would be much worse than that. Bizarre. That shouldn't cause a javadoc null point exception... |
@tomwhite This still had some issues with it, I pushed lb_java11 which should resolve them. Would you like to incorporate those changes into yours or should I create a new pr? |
@lbergelson thanks for looking at this. I had a look at your branch, but it wasn't clear how the changes related to Java 11. That said, please go ahead and merge as you see fit. |
@tomwhite They fix problems introduce by moving to gradle 5. It broke the |
closing this since I've taken it over in #1291 |
Description
Runs htsjdk's unit tests on Java 11.
Checklist