- Make Unique intervals keep both interval names even when intervals … #1265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1265 +/- ##
===============================================
+ Coverage 69.353% 69.357% +0.004%
- Complexity 8301 8302 +1
===============================================
Files 555 555
Lines 33116 33117 +1
Branches 5572 5572
===============================================
+ Hits 22967 22969 +2
+ Misses 7890 7886 -4
- Partials 2259 2262 +3
|
…are the same (assuming names are different) - added a test
yfarjoun
force-pushed
the
yf_keep_both_interval_names_on_merge
branch
from
19e57c6
to
e38e4bc
Compare
lbergelson
approved these changes
Jan 24, 2019
| int start = intervals.first().getStart(); | ||
| int end = intervals.last().getEnd(); | ||
| final boolean neg = intervals.first().isNegativeStrand(); | ||
| static Interval merge(final Iterable<Interval> intervals, final boolean concatenateNames) { |
There was a problem hiding this comment.
We should consider lifting it into Locatable as something like getSpanningLocatable. We'd have to decide on a concrete representation to instantiate though, so maybe that should wait until a different pr.
lbergelson
added a commit
that referenced
this pull request
Mar 6, 2019
* Fixing a bug in IntervalList.merge() that caused it to break when merging 0 length intervals * Improving tests for merge * The bug was introduced in #1265
lbergelson
added a commit
that referenced
this pull request
Mar 6, 2019
* Fixing a bug in IntervalList.merge() that caused it to break when merging 0 length intervals * Improving tests for merge * The bug was introduced in #1265
5 tasks
lbergelson
added a commit
that referenced
this pull request
Mar 7, 2019
* Fixing a bug in IntervalList.merge() that caused it to break when merging 0 length intervals * Improving tests for merge * The bug was introduced in #1265
lbergelson
added a commit
that referenced
this pull request
Mar 8, 2019
* Fixing a bug in IntervalList.merge() that caused it to break when merging 0 length intervals * Improving tests for merge * The bug was introduced in #1265
lbergelson
added a commit
that referenced
this pull request
Mar 11, 2019
* Fixing zero-length interval bug in IntervalList.merge * Fixing a bug in IntervalList.merge() that caused it to break when merging 0 length intervals * Improving tests for merge * The bug was introduced in #1265 * improving comment in IntervalList
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…are the same (assuming names are different)
Description
Please explain the changes you made here.
Explain the motivation for making this change. What existing problem does the pull request solve?
Checklist