Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated htsjdk.samtools.apps package. #1250

Merged
merged 1 commit into from
Jan 3, 2019

Conversation

lbergelson
Copy link
Member

  • deprecated TimeChannel and TimeRandomAccesFile
  • these are two tools which were probably used for testing at some point but should not be part of the htsjdk distribution

Description

Please explain the changes you made here.
Explain the motivation for making this change. What existing problem does the pull request solve?

Checklist

  • Code compiles correctly
  • New tests covering changes and new functionality
  • All tests passing
  • Extended the README / documentation, if necessary
  • Is not backward compatible (breaks binary or source compatibility)

* deprecated TimeChannel and TimeRandomAccesFile
* these are two tools which were probably used for testing at some point but should not be part of the htsjdk distribution
@codecov-io
Copy link

codecov-io commented Jan 2, 2019

Codecov Report

Merging #1250 into master will increase coverage by 0.003%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##              master     #1250       +/-   ##
===============================================
+ Coverage     69.384%   69.387%   +0.003%     
- Complexity      8157      8158        +1     
===============================================
  Files            548       548               
  Lines          32702     32702               
  Branches        5522      5522               
===============================================
+ Hits           22690     22691        +1     
  Misses          7794      7794               
+ Partials        2218      2217        -1
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/htsjdk/samtools/apps/TimeChannel.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...ava/htsjdk/samtools/apps/TimeRandomAccessFile.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...va/htsjdk/samtools/sra/SRAIndexedSequenceFile.java 64.865% <0%> (+2.703%) 7% <0%> (+1%) ⬆️

@lbergelson lbergelson merged commit 2737292 into master Jan 3, 2019
@lbergelson lbergelson deleted the lb_deprecate_samtools_apps branch January 3, 2019 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants