resolving some nitpicks from pr #1245 #1246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbergelson
force-pushed
the
lb_resolve_nitpicks
branch
from
6e343b2
to
349a87d
Compare
Codecov Report
@@ Coverage Diff @@
## master #1246 +/- ##
===============================================
+ Coverage 69.407% 69.412% +0.004%
Complexity 8157 8157
===============================================
Files 548 548
Lines 32691 32689 -2
Branches 5521 5521
===============================================
Hits 22690 22690
+ Misses 7783 7781 -2
Partials 2218 2218
|
|
Looks like there is a tiiiny coverage drop thanks to an exception being thrown when stream does not have "markSupported". And apparently the MD5 hashing somehow shook out to work so that nobody ever hits MD5 hashes shorter than 32 so no need to pad them (?)... I can try helping with that if you want, but it looks very minor. |
|
@romanzenka Thank you for the offer, I wouldn't worry about that, our coverage detection always fails do to minor changes. I need to fix it... |
yfarjoun
reviewed
Dec 20, 2018
| @@ -99,6 +99,8 @@ | |||
| public static final String COMPRESSED_VCF_INDEX_EXTENSION = ".tbi"; | |||
|
|
|||
|
|
|||
|
|
|||
| @@ -50,7 +51,7 @@ public static VCFHeader readHeaderFrom(final SeekableStream in) throws IOExcepti | |||
| private static InputStream bufferAndDecompressIfNecessary(final InputStream in) throws IOException { | |||
| BufferedInputStream bis = new BufferedInputStream(in); | |||
| // despite the name, SamStreams.isGzippedSAMFile looks for any gzipped stream (including block compressed) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolving some nitpicks left over from pr #1245