-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding some constants due to additions to hts-spec #1241
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1241 +/- ##
===============================================
+ Coverage 69.376% 70.342% +0.966%
- Complexity 8140 9155 +1015
===============================================
Files 547 556 +9
Lines 32622 36301 +3679
Branches 5515 6420 +905
===============================================
+ Hits 22632 25535 +2903
- Misses 7772 8368 +596
- Partials 2218 2398 +180
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yfarjoun One nitpick and then good to merge.
can this be merged now? |
Co-Authored-By: yfarjoun <[email protected]>
- make constructor private
@lbergelson...I took your suggestions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good.
No description provided.