Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding some constants due to additions to hts-spec #1241

Merged
merged 4 commits into from
Jan 24, 2019

Conversation

yfarjoun
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Dec 12, 2018

Codecov Report

Merging #1241 into master will increase coverage by 0.966%.
The diff coverage is 100%.

@@               Coverage Diff               @@
##              master     #1241       +/-   ##
===============================================
+ Coverage     69.376%   70.342%   +0.966%     
- Complexity      8140      9155     +1015     
===============================================
  Files            547       556        +9     
  Lines          32622     36301     +3679     
  Branches        5515      6420      +905     
===============================================
+ Hits           22632     25535     +2903     
- Misses          7772      8368      +596     
- Partials        2218      2398      +180
Impacted Files Coverage Δ Complexity Δ
src/main/java/htsjdk/samtools/SAMTag.java 97.403% <100%> (+0.034%) 5 <0> (ø) ⬇️
...ain/java/htsjdk/variant/vcf/VCFInfoHeaderLine.java 85.714% <0%> (-14.286%) 8% <0%> (+3%)
...a/htsjdk/samtools/cram/io/CountingInputStream.java 49.153% <0%> (-8.54%) 11% <0%> (+5%)
...java/htsjdk/samtools/cram/io/CRC32InputStream.java 35.714% <0%> (-8.286%) 7% <0%> (+3%)
...c/main/java/htsjdk/samtools/BamIndexValidator.java 75% <0%> (-8.077%) 13% <0%> (+4%)
src/main/java/htsjdk/samtools/cram/io/CramInt.java 77.778% <0%> (-7.222%) 10% <0%> (+5%)
...cram/encoding/external/ExternalByteArrayCodec.java 75% <0%> (-6.818%) 6% <0%> (+2%)
...samtools/cram/compression/ExternalCompression.java 71.91% <0%> (-5.363%) 27% <0%> (+13%)
src/main/java/htsjdk/samtools/SamFiles.java 93.478% <0%> (-3.581%) 14% <0%> (ø)
...tsjdk/samtools/cram/io/DefaultBitOutputStream.java 73.718% <0%> (-3.555%) 35% <0%> (+9%)
... and 76 more

Copy link
Member

@lbergelson lbergelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yfarjoun One nitpick and then good to merge.

src/main/java/htsjdk/samtools/util/SamConstants.java Outdated Show resolved Hide resolved
@lbergelson lbergelson added the Waiting for revisions This PR has received comments from reviewers and is waiting for the Author to respond label Dec 17, 2018
@yfarjoun
Copy link
Contributor Author

can this be merged now?

lbergelson and others added 2 commits January 24, 2019 12:15
@yfarjoun
Copy link
Contributor Author

@lbergelson...I took your suggestions.

Copy link
Member

@lbergelson lbergelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good.

@lbergelson lbergelson merged commit d0b1a74 into master Jan 24, 2019
@lbergelson lbergelson deleted the yf_add_barcode_related_constants branch January 24, 2019 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Waiting for revisions This PR has received comments from reviewers and is waiting for the Author to respond
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants