Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing cruft leftover from JAXB #1207

Merged
merged 1 commit into from
Nov 14, 2018
Merged

Conversation

lbergelson
Copy link
Member

There were some things that could be cleaned up after removing JAXB support for SAMSequenceRecord.

Checklist

  • Code compiles correctly
  • New tests covering changes and new functionality
  • All tests passing
  • Extended the README / documentation, if necessary
  • Is not backward compatible (breaks binary or source compatibility)

* Removing some now unused methods minor cleanup in SAMSequenceRecord and SAMSequenceDictionary
@codecov-io
Copy link

codecov-io commented Oct 26, 2018

Codecov Report

Merging #1207 into master will increase coverage by 0.018%.
The diff coverage is 66.667%.

@@              Coverage Diff               @@
##              master    #1207       +/-   ##
==============================================
+ Coverage     68.702%   68.72%   +0.018%     
  Complexity      8061     8061               
==============================================
  Files            542      542               
  Lines          32711    32701       -10     
  Branches        5533     5532        -1     
==============================================
- Hits           22473    22472        -1     
+ Misses          8038     8029        -9     
  Partials        2200     2200
Impacted Files Coverage Δ Complexity Δ
...in/java/htsjdk/samtools/SAMSequenceDictionary.java 72.727% <ø> (ø) 45 <0> (ø) ⬇️
...c/main/java/htsjdk/samtools/SAMSequenceRecord.java 79.167% <66.667%> (+8.435%) 34 <0> (ø) ⬇️
...samtools/util/AsyncBlockCompressedInputStream.java 72% <0%> (-4%) 12% <0%> (-1%)
...sjdk/samtools/util/Md5CalculatingOutputStream.java 74.359% <0%> (+7.692%) 8% <0%> (+1%) ⬆️

Copy link
Contributor

@jamesemery jamesemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, all low impact removal 👍

@lbergelson lbergelson merged commit 9a4b241 into master Nov 14, 2018
@lbergelson lbergelson deleted the lb_remove_jaxb_constructor branch November 14, 2018 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants