-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More CRAM Encoding tests + updates #1203
Changes from all commits
7bd259b
8bbda87
d06de29
05a77d7
50d42e1
5fbd2ce
a058888
4cafed7
2a1ecbf
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,9 +13,8 @@ public class CramIntArray { | |
* | ||
* @param inputStream the inputs stream to read from | ||
* @return array of integers from the input stream | ||
* @throws IOException as per java IO contract | ||
*/ | ||
public static int[] array(final InputStream inputStream) throws IOException { | ||
public static int[] array(final InputStream inputStream) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Javadoc There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. good catch, thanks |
||
final int size = ITF8.readUnsignedITF8(inputStream); | ||
final int[] array = new int[size]; | ||
for (int i = 0; i < size; i++) | ||
|
@@ -30,9 +29,8 @@ public static int[] array(final InputStream inputStream) throws IOException { | |
* @param array the array to be written | ||
* @param outputStream the output stream to write to | ||
* @return the number of bits written out | ||
* @throws IOException as per java IO contract | ||
*/ | ||
public static int write(final int[] array, final OutputStream outputStream) throws IOException { | ||
public static int write(final int[] array, final OutputStream outputStream) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same as above. |
||
int length = ITF8.writeUnsignedITF8(array.length, outputStream); | ||
for (final int intValue : array) length += ITF8.writeUnsignedITF8(intValue, outputStream); | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay thanks.