Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the PS FORMAT VCF standard header field #1200

Merged
merged 1 commit into from
Oct 24, 2018
Merged

Conversation

nh13
Copy link
Member

@nh13 nh13 commented Oct 21, 2018

@lbergelson
Motivated by broadinstitute/gatk#5318

I am happy to change the language as folks see fit.

@nh13 nh13 force-pushed the nh_phase_set branch 2 times, most recently from 2e4d97f to 43f918c Compare October 21, 2018 01:32
@codecov-io
Copy link

codecov-io commented Oct 21, 2018

Codecov Report

Merging #1200 into master will increase coverage by 0.013%.
The diff coverage is 100%.

@@               Coverage Diff               @@
##              master     #1200       +/-   ##
===============================================
+ Coverage     68.503%   68.516%   +0.013%     
- Complexity      8032      8034        +2     
===============================================
  Files            542       542               
  Lines          32714     32715        +1     
  Branches        5534      5534               
===============================================
+ Hits           22410     22415        +5     
+ Misses          8099      8097        -2     
+ Partials        2205      2203        -2
Impacted Files Coverage Δ Complexity Δ
...ava/htsjdk/variant/vcf/VCFStandardHeaderLines.java 76.389% <100%> (+0.333%) 11 <0> (ø) ⬇️
...va/htsjdk/samtools/sra/SRAIndexedSequenceFile.java 64.865% <0%> (+2.703%) 7% <0%> (+1%) ⬆️
...samtools/util/AsyncBlockCompressedInputStream.java 76% <0%> (+4%) 13% <0%> (+1%) ⬆️

Copy link
Member

@lbergelson lbergelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nh13 Thank you. This seems good to me.

@lbergelson
Copy link
Member

Lets give it another day or two to let people have a chance to see it in case there are any suggestions to the phrasing.

@lbergelson
Copy link
Member

No one responded so I'm going to merge this. Thank you @nh13

@lbergelson lbergelson merged commit 334800e into master Oct 24, 2018
@lbergelson lbergelson deleted the nh_phase_set branch October 24, 2018 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants