-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support BAMs with >65535 CIGAR operations #1003
Commits on Dec 16, 2017
-
Support BAMs with >65535 CIGAR operations
This is the solution that @yfarjoun and I have agreed on. In the presence of CIGAR with >65535 operators, we move the real CIGAR to the CG tag and put a fake full clipping CIGAR (i.e. <readLength>S) in place. `./gradlew` reported one test failure due to `EnaRefServiceTest`. Looking at the call stack, I don't think that is my fault. The rest of tests have passed. On an example SAM and BAM (from <http://lh3lh3.users.sourceforge.net/data>), `PrintReadsExample` gives the desired BAM output when taking both SAM and BAM as input. Both shallow and deep decoding also write correct BAMs.
Configuration menu - View commit details
-
Copy full SHA for c871a7c - Browse repository at this point
Copy the full SHA c871a7cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1426a0f - Browse repository at this point
Copy the full SHA 1426a0fView commit details -
keep indexingBin in sync for long-cigar records
For BAMs generated with old tools, the indexingBin field may not be correctly set. We need to manually update this field to avoid errors during random retrieval.
Configuration menu - View commit details
-
Copy full SHA for be74e75 - Browse repository at this point
Copy the full SHA be74e75View commit details -
fixed bugs in the long-cigar code
The old code to lift tag to CIGAR did not work. This commit fixed several issues: - byte order is not set when computing alignmentEnd - forgot to add *4 to cigarLen in two cases - getChar() is not what it is supposed to mean The new code has been more carefully tested and seems to work.
Configuration menu - View commit details
-
Copy full SHA for a2b45d6 - Browse repository at this point
Copy the full SHA a2b45d6View commit details -
Configuration menu - View commit details
-
Copy full SHA for a5f1156 - Browse repository at this point
Copy the full SHA a5f1156View commit details -
Configuration menu - View commit details
-
Copy full SHA for f5d56bd - Browse repository at this point
Copy the full SHA f5d56bdView commit details -
Configuration menu - View commit details
-
Copy full SHA for cc87242 - Browse repository at this point
Copy the full SHA cc87242View commit details -
Configuration menu - View commit details
-
Copy full SHA for 516c7fa - Browse repository at this point
Copy the full SHA 516c7faView commit details
Commits on Dec 20, 2017
-
- one test failed due to validation failure on empty cigar...so I fix…
…ed the SamSetRecordBuilder..
Configuration menu - View commit details
-
Copy full SHA for f44fe98 - Browse repository at this point
Copy the full SHA f44fe98View commit details -
- one test failed due to validation failure on empty cigar...so I fix…
…ed the SamSetRecordBuilder..
Configuration menu - View commit details
-
Copy full SHA for 2bdd694 - Browse repository at this point
Copy the full SHA 2bdd694View commit details -
Configuration menu - View commit details
-
Copy full SHA for ca53a6c - Browse repository at this point
Copy the full SHA ca53a6cView commit details