Skip to content

Commit

Permalink
moving HttpUtilsTest to externalApi test task (#1289)
Browse files Browse the repository at this point in the history
* HttpUtilsTest is flakey because it connects to remote web servers.
Moved it to the testExternalAPIs test task
* changed a broken link so that the tests pass again
  • Loading branch information
lbergelson authored Feb 18, 2019
1 parent 62fc0b1 commit 38bfe65
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
4 changes: 3 additions & 1 deletion build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,7 @@ test {
exclude "broken"
exclude "defaultReference"
exclude "ftp"
exclude "http"
exclude "sra"
exclude "ena"

Expand All @@ -127,11 +128,12 @@ task testFTP(type: Test) {
}

task testExternalApis(type: Test) {
description = "Run the SRA and ENA tests (tests that interact with external APIs)"
description = "Run the SRA, ENA, and HTTP tests (tests that interact with external APIs)"
jvmArgs += '-Dsamjdk.sra_libraries_download=true'

tags {
include "sra"
include "http"
include "ena"
exclude "slow"
exclude "broken"
Expand Down
3 changes: 2 additions & 1 deletion src/test/java/htsjdk/samtools/util/HttpUtilsTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,13 @@

import htsjdk.HtsjdkTest;

@Test(groups = "http")
public class HttpUtilsTest extends HtsjdkTest {
@DataProvider(name = "existing_urls")
public Object[][] testExistingURLsData() {
return new Object[][]{
{"http://broadinstitute.github.io/picard/testdata/index_test.bam"},
{"http://ftp.1000genomes.ebi.ac.uk/vol1/ftp/current.tree"}
{"http://ftp.1000genomes.ebi.ac.uk/vol1/ftp/README_using_1000genomes_cram.md"}
};
}

Expand Down

0 comments on commit 38bfe65

Please sign in to comment.