Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
I want to initiate a discussion/review. I've made work on performance optimization. It gives ~20x boost in tests with defined date and ~10x with current date on Node.js. http://jsperf.com/strftime-optimization
I changed the API (#29) which looks like:
I rewrote almost all the code from scratch but it is pretty simple and easy to read. I adapted tests to new API but they need refactoring. Please spend some time to review the code. Looking forward to your feedback.