This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
aws: update RDS resources to remove calls to ListTagsForResource #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This API call is no longer necessary since with the new SDK, all the tags are already returned in the Describe* calls. This will cut down on the number of API calls terraform is making during state refreshes.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This API call is no longer necessary since with the new SDK, all the tags are
already returned in the Describe* calls. This will cut down on the number of
API calls terraform is making during state refreshes.
We can build a binary off of this branch and update the master branch whenever we need to bump the version of our provider.
Output from acceptance testing (ran make test + tests for aws package and each resource modified):