Allow Plyr.setup event listeners to be set up as separate event listeners #703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rather than in-conjunction with defaultListener This allows the setup listeners to do things like preventDefault()/stopImmediatePropagation() and have them work
sampotts
approved these changes
Nov 4, 2017
|
Cheers - will retrofit this to |
filips123
pushed a commit
to filips123/plyr
that referenced
this pull request
Nov 22, 2018
Allow Plyr.setup event listeners to be set up as separate event listeners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the setup listeners to do things like
preventDefault()/stopImmediatePropagation() and have them work
Link to related issue (if applicable)
There is an issue comment
Sumary of proposed changes
Earlier, if a
listenerwas specified duringPlyr.setup(), we set up one event handler with both the provided listener (userListener) as well as thedefaultListener.Now, each of these is attached as a separate event listener (
userListenerbeing attached first).This ensures that
preventDefault()/stopImmediatePropagation()are handled correctly.Task list