Add blankUrl option to set the URL for blank.mp4 #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is useful for people behind firewalls who need to host a blank mp4 themselves.
|
Can you make sure you run gulp to generate the compressed files as per the contributing docs? |
|
I couldn't find the contributing docs :( I'll run gulp now |
|
Done |
|
Any word on this? |
sampotts
approved these changes
Mar 24, 2017
|
This is in the latest version 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of my projects are behind VPNs with strict firewalls. I need to be able to self-host the blank.mp4 file used to cancel network requests. This allows you to specify the URL that is set.