Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tooltip seek render bug #2549

Closed
wants to merge 1 commit into from
Closed

fix tooltip seek render bug #2549

wants to merge 1 commit into from

Conversation

raad-altaie
Copy link
Contributor

Link to related issue (if applicable)

Summary of proposed changes

white-space: normal;

Screen Shot 2022-10-23 at 5 53 48 PM

white-space: nowrap;
Screen Shot 2022-10-23 at 5 53 17 PM

@raad-altaie raad-altaie changed the title fix tooltip progress render bug fix tooltip seek render bug Oct 23, 2022
@@ -27,7 +27,7 @@ $plyr-progress-offset: $plyr-range-thumb-height;
left: 0;
max-width: 120px;
overflow-wrap: break-word;
white-space: normal;
white-space: nowrap;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change and sorry for the slow review! We can remove this line completely since the default white-space value for .plyr__tooltip is nowrap.

@sampotts
Copy link
Owner

Thanks for doing the work on this. I've just removed the line as per my comment for now. Cheers!

@sampotts sampotts closed this Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants