Added configurable property to elements for re-use #2489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sampotts
approved these changes
Sep 9, 2022
adeeb1
pushed a commit
to ClassHook/plyr
that referenced
this pull request
Oct 11, 2022
adeeb1
added a commit
to ClassHook/plyr
that referenced
this pull request
Oct 13, 2022
* Fix typo. * remove redundant local variable (sampotts#2467) * fix invalid CSS @charset rule (sampotts#2466) * remove deprecated keyCode (sampotts#2461) * remove deprecated keyCode (sampotts#2463) * fix: use consistent border-radius variable * fix JSDoc comments (sampotts#2468) * feat: minor tweaks to the preview thumbs UI * Improve accessibility on control buttons with aria-pressed (sampotts#2523) * Added configurable property to elements for re-use (sampotts#2489) * navigator.platform is deprecated (sampotts#2530) I'm submitting a little update for browser detection: 1. `navigator.platform` is deprecated - it's prefered to use `navigator.userAgent` https://developer.mozilla.org/en-US/docs/Web/API/Navigator/platform 2. No need for the brackets in the RegEx - you can test this on https://regex101.com And that's about it. Maybe I missed the point, do let me know! ❤️ * fix: add babel plugin to transform optional chaining * Update dist files. Co-authored-by: Hashen <[email protected]> Co-authored-by: Sam Potts <[email protected]> Co-authored-by: Emil Karlsson <[email protected]> Co-authored-by: NoirHusky <[email protected]> Co-authored-by: Nikola Stamatović <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently, if you make a Plyr instance with custom elements. Plyr declares some of the properties in the element as non-configurable. So, if you want to destroy that Plyr instance and instantiate it again, Javascript complains of redefining a non-configurable property 'pressed'. This happens only when the custom elements are an object and not a strings btw.
Link to related issue (if applicable)
No, issue precisely about this was opened.
Summary of proposed changes
One line was added to make 'pressed' property configurable.