Repository navigation
[KV Offload] Opt-in Core transfer path for P2P — review MVP - #2
Draft
samnordmann wants to merge 2 commits into
Draft
samnordmann wants to merge 2 commits into
samnordmann wants to merge 2 commits into
Conversation
Snapshot of the current endpoint-transfer prototype for review in the author's fork. Native GPU performance parity and full end-to-end framework validation remain open; this is not an upstream-ready change. Assisted-by: OpenAI Codex Signed-off-by: Samuel Nordmann <snordmann@nvidia.com>
This was referenced Sep 17, 2026
Keep the native P2P transport, session protocol and default behavior. Add a small Core-path switch and focused completion test; remove shared lifecycle changes. Assisted-by: OpenAI Codex Signed-off-by: Samuel Nordmann <snordmann@nvidia.com>
samnordmann
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Add
transfer_api="torch"to P2P CPU-tier offload. Wrap the existing NIXL agent through Core and the shared NIXL shim. Default stays native. No session, wire, lifecycle or unrelated connector changes.This is an API experiment, not the submission-failure fix in upstream #55553. Open P2P/NIXL work was checked again on 2026-09-17.
Test plan / result
.venv/bin/python -m pytest -q --confcutdir=tests/v1/kv_offload/tiering tests/v1/kv_offload/tiering: 372 passed, 11 skipped, with the Core source overlay; native calls are mocked. Added a peer-scoped completion test through the real shim. Selected-file pre-commit checks passed.No GPU/model evaluation or throughput result. Success-path prototype only; active cancellation/failure recovery is unsupported. Fork draft, AI-assisted; human line-by-line review and native end-to-end testing remain required.