Repository navigation
fix(pd-disagg): Fix vectorized_5d Mooncake KV Transfer - #23
Merged
Merged
Conversation
sammysun0711
force-pushed
the
fix/pd-disagg-vectorized-5d-kv
branch
2 times, most recently
from
August 28, 2026 02:19
613a063 to
ec1a1e2
Compare
sammysun0711
marked this pull request as ready for review
August 28, 2026 02:24
There was a problem hiding this comment.
🟡 Changes recommended
The decode launcher can terminate before startup, several scripts mask failures, and the regression fix lacks coverage.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Fixes Mooncake KV transfer sizing for page-major vectorized_5d caches and adds MiMo-V2.5-Pro PD deployment tooling.
Changes:
- Corrects RDMA page-byte calculations.
- Adds TP8 prefill/decode launch and benchmark scripts.
- Documents the 1P1D deployment workflow.
File summaries
| File | Description |
|---|---|
python/sglang/srt/mem_cache/memory_pool.py |
Calculates layout-aware KV page sizes. |
evaluation/mimo-v2.5-pro-evaluation-guide.md |
Links the PD guide. |
evaluation/mimo_pd_scripts/run_benchmark_mimo_pro_prefill.sh |
Adds prefill benchmarking. |
evaluation/mimo_pd_scripts/run_benchmark_mimo_pro_decode.sh |
Adds decode benchmarking. |
evaluation/mimo_pd_scripts/mimo-v2.5-pro-pd-disaggregated-guide.md |
Documents deployment steps. |
evaluation/mimo_pd_scripts/launch_tp8_noep_prefill_aiter_mtp.sh |
Configures the prefill server. |
evaluation/mimo_pd_scripts/launch_tp8_noep_decode_aiter_mtp.sh |
Configures the decode server. |
evaluation/mimo_pd_scripts/launch_router.sh |
Launches the PD router. |
Review details
Suppressed comments (1)
evaluation/mimo_pd_scripts/launch_tp8_noep_decode_aiter_mtp.sh:73
- Because this script enables
set -ubut never initializesMC_CUSTOM_TOPO_JSON, the documented launch exits here with “unbound variable” before starting the decode server whenever that optional Mooncake variable is unset. Render an explicit fallback in the status line.
echo "PD decode: mooncake, ib-device=${DISAGGREGATION_IB_DEVICE}, gid-index=${MC_GID_INDEX}, host-ip=${SGLANG_HOST_IP}, topo=${MC_CUSTOM_TOPO_JSON}"
- Files reviewed: 8/8 changed files
- Comments generated: 7
- Review effort level: Balanced
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
… transfer - Fix mooncake kv transfer issue with sglang vectorized_5d kv - Root cause: vectorized_5d kv stores one page in buf[0], while original NHD layout use nbytes * page_size overshoots registered MRs and blacklists kv cache transfer decode node. - Add MiMo TP8 1P1D launch/bench scripts and guide in `mimo_pd_scripts`. Signed-off-by: Xiake Sun <xiake.sun@amd.com>
sammysun0711
force-pushed
the
fix/pd-disagg-vectorized-5d-kv
branch
from
August 28, 2026 02:37
ec1a1e2 to
2ca1cf1
Compare
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Xiake Sun <xiake.sun@amd.com>
Signed-off-by: Xiake Sun <xiake.sun@amd.com>
sammysun0711
force-pushed
the
fix/pd-disagg-vectorized-5d-kv
branch
from
August 28, 2026 03:20
5da63ee to
bb0834b
Compare
Cover NHD vs page-major vectorized_5d so get_contiguous_buf_infos does not scale a full page by page_size again. Signed-off-by: Xiake Sun <xiake.sun@amd.com>
sammysun0711
force-pushed
the
fix/pd-disagg-vectorized-5d-kv
branch
from
August 28, 2026 04:17
b4ea75e to
549422f
Compare
Signed-off-by: Xiake Sun <xiake.sun@amd.com>
sammysun0711
force-pushed
the
fix/pd-disagg-vectorized-5d-kv
branch
from
August 28, 2026 04:24
2ecfaa7 to
e1411a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR aim to enable MiMO-V2.5-Pro PD Disaggregated Deployment with
vectorized_5dKV cache and provide MiMo TP8 1P1D guide and scripts underevaluation/mimo_pd_scriptsModifications
Fix Mooncake PD KV transfer for
SGLANG_AITER_KV_CACHE_LAYOUT=vectorized_5d:get_contiguous_buf_infos()treatedbuf[0]as one token (NHD) and usednbytes * page_size, which overshoots registered MRs and blacklists the decode session. vectorized_5d KV is page-major, use page-major item_len for vectorized_5d Mooncake KV transfer asbuf[0].nbytes.Add MiMo TP8 1P1D launch/bench scripts and guide under
evaluation/mimo_pd_scriptsAccuracy Tests
python3 -m pytest -q test/manual/test_disagg_page_nbytes.py: 3 passed.Benchmarking and Profiling
Checklist
Review Process
/tag-run-ci-label,/rerun-failed-ci,/tag-and-rerun-ci