-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for bigint #366
Conversation
Could you update the readme otherwise lgtm |
Thanks! I had overlooked that. |
Oh... I was wondering why only BIgInt is not supported, maybe because metadevpro/openapi3-ts does not support bigint and you dare not support it? |
I'm not entirely sure what you mean by that to be honest. The contents of your PR seem fine to me |
Thanks for the reply, samchungy. maximum/minimum/multipleOf in SchemaObject is number type, so bigint cannot be set.
I think the latter will suffice for most of my use cases. |
I think if you're using bigint you're not going to really need min/max, not to mention like you said JSON Schema wouldn't be able to display it anyway |
Thanks for your advice🙇🏻♂️ certainly agree with your thoughts. I have appended it to README.md. I did not include a note on the min/max matter, but will write one if necessary. |
e363ce0
to
d7df9cf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I have implemented support for bigint type 😄
The schema is output as integer(int64).
If I am missing any considerations, please point them out🙇🏻♂️